Two tests failed as they always do on AppVeyor (see issue #213), but for the rest the results were good.Īs I was curious what would happen if the JSON file was not found, I pushed another change, intentionally containing the wrong JSON file name (see here and here) and the result was glob returning an empty list ( ), thus is_anaconda() returning False, pydot looking for. Then, for Windows, I pushed your change to AppVeyor (with some debug code, see here and here) and it correctly detected that it was running under Windows, found the JSON file, returned True for is_anaconda() and correctly looked for the.
Graphviz through anaconda, pydot through pip, and vice versa), possibly with some other versions? And/or, could you revert your own fix and test PR #208 (propagate SYSTEMROOT) to see if that also solves the problem?Ĭomments by other Windows users would be very welcome as That looks like a solution! Even though I do not run Windows/Anaconda/conda myself, I tried to review it with the help of AppVeyor.įirst, on my laptop running Linux, there was no change in behavior of course, because is_windows() returns False already, so it never arrives at is_anaconda() (or is_anacoda(), #209 fixes that typo). pip in an anaconda environment)? Could you supply the version numbers? Would you be able to test your solution in setups of various combinations (e.g.
How did you install pydot and Graphviz? Using anaconda, conda, pip or a combination of these (e.g.
exe extension troubles are related to the installation method. Previous discussions (above, and the links from there) indicate that these.
Nor do I see any proof that the changed code has been tested under different setups. Both basically do away with some older control logic without explaining why that would not be needed for other users anymore. I get the impression that they are merely quick fixes for specific setups. I do not use Windows, so it is difficult for me to evaluate the suggested solutions. I invite both of them to continue the discussion in this issue ( #205). Note that this would result in the function no longer returning.
Later, an issue was created upstream asking for a better solution than.
That commit message links to the responsible 'upstream' code in conda-forge/graphviz-feedstock.
bat-code discussed in pydot/pydot-ng#52 to pydot/pydot instead ( 8c55fe5).